WIP - Ember Table Implementation#6397
Conversation
|
Important Review skippedToo many files! This PR contains 469 files, which is 319 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (469)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rtablada
changed the title
rtablada
force-pushed
the
feat-ember-table-example-basic-external-state
branch
from
4aaf1e6 to
e83347d
Compare
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Port the Lit basic-external-state example to Ember, demonstrating external management of sorting and pagination state via @Tracked properties and onSortingChange/onPaginationChange handlers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix: bad object first arg
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rtablada
force-pushed
the
feat-ember-table-example-basic-external-state
branch
from
2f67891 to
54e1c49
Compare
|
|
||
| const externalState = state[key as keyof typeof state] | ||
| if (externalState !== baseAtom.get()) { | ||
| if (externalState !== table._reactivity.untrack(() => baseAtom.get())) { |
There was a problem hiding this comment.
This was required for Ember since setting and getting the same signal in one cycle throws an error.
This was causing errors for external state and external atom initialization
There was a problem hiding this comment.
Tbf tho, any strict signals implementation will have an issue here, like the tc39 sample impl
|
View your CI Pipeline Execution ↗ for commit 07f7f5a
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/alpine-table
@tanstack/angular-table
@tanstack/angular-table-devtools
@tanstack/ember-table
@tanstack/lit-table
@tanstack/match-sorter-utils
@tanstack/preact-table
@tanstack/preact-table-devtools
@tanstack/react-table
@tanstack/react-table-devtools
@tanstack/solid-table
@tanstack/solid-table-devtools
@tanstack/svelte-table
@tanstack/table-core
@tanstack/table-devtools
@tanstack/vue-table
@tanstack/vue-table-devtools
commit: |
3 participants
🎯 Changes
This PR is the initial proposed implementation for an Ember.js adapter for Tanstack Table.
This is heavily based on Lit with learnings from the Angular implementation since Ember patterns and public signals API lay somewhere between these two frameworks.
This replaces previous work #6362
Based on thread from Discord between @rtablada @KevinVandy and @NullVoxPopuli this implements the state reactivity and flex-render.
✅ Checklist
pnpm test:pr.Notes
Two things are a bit different here:
createAtom@argsis semi-reserved with Ember and can cause lint errors for consuming apps so@optionsis used for flex render internally and types match this.sherifwill need to be configured ignore it for this version